From 8a57f3d948df625602e96d94dc696eb551af8fcf Mon Sep 17 00:00:00 2001 From: huangzy Date: Wed, 19 Jul 2023 16:43:37 +0800 Subject: [PATCH] rbd: fix CreateSnapshot panic add if rbdVol != nil defer rbdVol.Destroy() Signed-off-by: huangzy --- internal/rbd/controllerserver.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/internal/rbd/controllerserver.go b/internal/rbd/controllerserver.go index bd00d148f6b..a9b1a814688 100644 --- a/internal/rbd/controllerserver.go +++ b/internal/rbd/controllerserver.go @@ -1078,7 +1078,9 @@ func (cs *ControllerServer) CreateSnapshot( // Fetch source volume information rbdVol, err := GenVolFromVolID(ctx, req.GetSourceVolumeId(), cr, req.GetSecrets()) - defer rbdVol.Destroy() + if rbdVol != nil { + defer rbdVol.Destroy() + } if err != nil { switch { case errors.Is(err, ErrImageNotFound):