From f371aa267746fefc28cbfa881cd043049a0f5b06 Mon Sep 17 00:00:00 2001 From: Niels de Vos Date: Mon, 7 Aug 2023 13:30:36 +0200 Subject: [PATCH] ci: use `podman` for simple GitHub workflows `podman` is installed by default on the Ubuntu runners. Podman is recommended for developers and contributors, as there are no elevated privileges required to run it. Docker requires extra permissions to build and or run container images, and contributors to Ceph-CSI should not need to spend time working with that (several developers run the `docker` command with `sudo`, which is discouraged). Only the multi-arch Workflows require Docker, for the time being. Signed-off-by: Niels de Vos --- .github/workflows/codespell.yaml | 2 +- .github/workflows/commitlint.yaml | 2 +- .github/workflows/go-test.yaml | 4 ++-- .github/workflows/golangci-lint.yaml | 2 +- .github/workflows/lint-extras.yaml | 2 +- .github/workflows/mod-check.yaml | 2 +- 6 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/codespell.yaml b/.github/workflows/codespell.yaml index 29e4711d927..3764ccfdca8 100644 --- a/.github/workflows/codespell.yaml +++ b/.github/workflows/codespell.yaml @@ -17,4 +17,4 @@ jobs: steps: - uses: actions/checkout@v3 - name: codespell - run: CONTAINER_CMD=docker make containerized-test TARGET=codespell + run: make containerized-test TARGET=codespell diff --git a/.github/workflows/commitlint.yaml b/.github/workflows/commitlint.yaml index bc637a600c8..84169476b46 100644 --- a/.github/workflows/commitlint.yaml +++ b/.github/workflows/commitlint.yaml @@ -19,4 +19,4 @@ jobs: ref: ${{ github.event.pull_request.head.sha }} - name: commitlint # yamllint disable-line rule:line-length - run: make containerized-test CONTAINER_CMD=docker TARGET=commitlint GIT_SINCE="origin/${GITHUB_BASE_REF}" + run: make containerized-test TARGET=commitlint GIT_SINCE="origin/${GITHUB_BASE_REF}" diff --git a/.github/workflows/go-test.yaml b/.github/workflows/go-test.yaml index 17c3a685ec3..741456fe834 100644 --- a/.github/workflows/go-test.yaml +++ b/.github/workflows/go-test.yaml @@ -15,11 +15,11 @@ jobs: steps: - uses: actions/checkout@v3 - name: go-test - run: CONTAINER_CMD=docker make containerized-test TARGET=go-test + run: make containerized-test TARGET=go-test go-test-api: name: go-test-api runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 - name: go-test-api - run: CONTAINER_CMD=docker make containerized-test TARGET=go-test-api + run: make containerized-test TARGET=go-test-api diff --git a/.github/workflows/golangci-lint.yaml b/.github/workflows/golangci-lint.yaml index 37ac0b376f1..7b5af26ec76 100644 --- a/.github/workflows/golangci-lint.yaml +++ b/.github/workflows/golangci-lint.yaml @@ -15,4 +15,4 @@ jobs: steps: - uses: actions/checkout@v3 - name: golangci-lint - run: CONTAINER_CMD=docker make containerized-test TARGET=go-lint + run: make containerized-test TARGET=go-lint diff --git a/.github/workflows/lint-extras.yaml b/.github/workflows/lint-extras.yaml index 23afffa1647..10367a82c8c 100644 --- a/.github/workflows/lint-extras.yaml +++ b/.github/workflows/lint-extras.yaml @@ -15,4 +15,4 @@ jobs: steps: - uses: actions/checkout@v3 - name: lint-extras - run: CONTAINER_CMD=docker make containerized-test TARGET=lint-extras + run: make containerized-test TARGET=lint-extras diff --git a/.github/workflows/mod-check.yaml b/.github/workflows/mod-check.yaml index 10e22d783a5..79e3dff387b 100644 --- a/.github/workflows/mod-check.yaml +++ b/.github/workflows/mod-check.yaml @@ -15,4 +15,4 @@ jobs: steps: - uses: actions/checkout@v3 - name: mod-check - run: CONTAINER_CMD=docker make containerized-test TARGET=mod-check + run: make containerized-test TARGET=mod-check