Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle multiple storage classes in Helm chart #4484

Open
gpothier opened this issue Mar 10, 2024 · 2 comments
Open

Handle multiple storage classes in Helm chart #4484

gpothier opened this issue Mar 10, 2024 · 2 comments
Labels
component/deployment Helm chart, kubernetes templates and configuration Issues/PRs enhancement New feature or request

Comments

@gpothier
Copy link

Describe the feature you'd like to have

The Helm chart currently supports the creation of one StorageClass. I think it could be useful to allow the creation of multiple storage classes, given that the chart already supports the configuration of various clusters (through the array in csiConfig).

Eg. instead of:

storageClass:
  # Specifies whether the Storage class should be created
  create: true
  name: mysc
  clusterID: xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx
  fsName: myfs

we could have:

storageClasses: {}

if no StorageClass should be created, or:

storageClasses:
  mysc:
    clusterID: xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx
    fsName: myfs
  myothersc:
    clusterID: xxxxxxxx-xxxx-xxxx-xxxx-yyyyyyyyyyyy
    fsName: myotherfs

(I am partial to using maps instead of arrays as it makes it easier to add different items by providing multiple values files which are then merged).

What is the value to the end user? (why is it a priority?)

In my particular use case, I need a storage class for volumes that contain important data that needs to be included in backups, and another one for volumes that contain temporary data, or data that does not need to be backed up.

How will we know we have a good solution? (acceptance criteria)

The feature should work correctly and be clearly documented

@nixpanic nixpanic added enhancement New feature or request component/deployment Helm chart, kubernetes templates and configuration Issues/PRs labels Mar 21, 2024
@mustdiechik
Copy link
Contributor

you can do it via extraDeploy (Secret + StorageClass )

@gpothier
Copy link
Author

gpothier commented Apr 9, 2024

Yes, but that would be quite a lot of lines for each extra StorageClass, instead of just two lines, and we would have one SC defined in one way, and the rest defined in a completely different way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/deployment Helm chart, kubernetes templates and configuration Issues/PRs enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants