rbd: VolumeGroupSnapshot support #4502
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixpanic
force-pushed
the
rbd/group-snapshot
branch
from
25e7f97
to
65c17e7
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions. |
nixpanic
force-pushed
the
rbd/group-snapshot
branch
3 times, most recently
from
57e136d
to
6d85b34
Compare
|
This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏 |
nixpanic
force-pushed
the
rbd/group-snapshot
branch
from
6d85b34
to
d60f341
Compare
nixpanic
force-pushed
the
rbd/group-snapshot
branch
from
d60f341
to
3722692
Compare
The `repairImageID()` function is useful for the `rbdSnapshot` objects as well. Move it to the `rbdImage` struct that is the base for both `rbdVolume` and `rbdSnapshot`. Signed-off-by: Niels de Vos <ndevos@ibm.com>
There is no need for the `Manager.DeleteVolumeGroup()` function as `VolumeGroup.Delete()` should cover everything too. By moving the `.Delete()` functionality of removing the group from the journal to the shared `commonVolumeGroup` type, a volume group snaphot can use it as well. Signed-off-by: Niels de Vos <ndevos@ibm.com>
When a snapshot has been created, it is always ready to be used immediately. Signed-off-by: Niels de Vos <ndevos@ibm.com>
Signed-off-by: Niels de Vos <ndevos@ibm.com>
Signed-off-by: Niels de Vos <ndevos@ibm.com>
Signed-off-by: Niels de Vos <ndevos@ibm.com>
Signed-off-by: Niels de Vos <ndevos@ibm.com>
Signed-off-by: Niels de Vos <ndevos@ibm.com>
… too! Signed-off-by: Niels de Vos <ndevos@ibm.com>
nixpanic
force-pushed
the
rbd/group-snapshot
branch
from
3722692
to
0ca9915
Compare
|
/test ci/centos/mini-e2e-helm/k8s-1.30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Posting early for initial reviewing. Some parts can be split from this large PR into smaller pieces.
Notable changes:
internal/rbd_typespackage with interfaces so that objects can be passed around cleanerinternal/rbd/volume.goimplementing the newVolumeinterface forrbdImageinternal/rbd_grouppackage for all RBD-group functionalitiesinternal/rbd/group_controller.gofor all CSI VolumeGroup service proceduresCommits in the current form will mostly change majorly. Reviewing per commit is not recommended, only check the files that you are interested in 😉
Depends-on: #4794
Depends-on: #4870
Depends-on: #4871
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)