Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

csi-addons/rbd: make use of volume locks for reclaim space operations #4637

Open
Rakshith-R opened this issue May 23, 2024 · 2 comments · May be fixed by #4641
Open

csi-addons/rbd: make use of volume locks for reclaim space operations #4637

Rakshith-R opened this issue May 23, 2024 · 2 comments · May be fixed by #4641
Assignees
@iPraveenParihar
Labels
component/rbd Issues related to RBD dependency/csi-addons Related to a CSI-Addons issue or enhancement

Comments

@Rakshith-R
Copy link
Contributor

Describe the bug

Reclaim space operations need to be protected with volume locks similar to other calls to prevent multiple process executing rbd sparsify / fstrim on same volume.

refer: https://github.com/ceph/ceph-csi/blob/devel/internal/csi-addons/rbd/replication.go#L238

Environment details

  • Image/version of Ceph CSI driver : all
  • Helm chart version : all
  • Kernel version : all
  • Mounter used for mounting PVC (for cephFS its fuse or kernel. for rbd its
    krbd or rbd-nbd) : krbd
  • Kubernetes cluster version : all
  • Ceph cluster version : all

Steps to reproduce

Steps to reproduce the behavior:

  1. Setup details: '...'
  2. Deployment to trigger the issue '....'
  3. See error

Actual results

Multiple rbd sparsify/ fstrim can be triggered in case the process takes too long and controller times out.

Expected behavior

Only one rbd sparsify/ fstrim process per volume should run at a time.
@Rakshith-R Rakshith-R added component/rbd Issues related to RBD dependency/csi-addons Related to a CSI-Addons issue or enhancement labels May 23, 2024
@iPraveenParihar iPraveenParihar linked a pull request May 27, 2024 that will close this issue
Open
6 tasks
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the wontfix This will not be worked on label Jun 22, 2024
@github-actions GitHub Actions
Copy link

This issue has been automatically closed due to inactivity. Please re-open if this still requires investigation.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 29, 2024
@iPraveenParihar iPraveenParihar removed the wontfix This will not be worked on label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iPraveenParihar iPraveenParihar

Labels
component/rbd Issues related to RBD dependency/csi-addons Related to a CSI-Addons issue or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rbd: add volume locks for reclaimspace operations iPraveenParihar/ceph-csi
2 participants
@iPraveenParihar @Rakshith-R