Ensure ceph-lock is always released when staging encrypted cephfs volume

[NymanRobin]

Issue:

The current implementation of unlocking an encrypted filesystem in the NodeServer leaves a "hanging lock" (timeout duration will eventually clean this) if fscrypt fails to unlock. This causes unnecessary delays and negatively impact performance as this could be easily be avoided by pushing the unlocking of the lock directly to the defer stack after the lock has been acquired.

Solution:

For more information on the issue and potential solution please see this comment chain in the original PR: #4697 (review)

[NymanRobin]

I have not tested yet the new implementation but I have a tingling feeling from earlier testing that this might be occurring here and there. If it is the cases the root-cause could of course be narrowed down in addition to this change.

[github-actions]

Thanks for taking this issue! Let us know if you have any questions!

[Sunnatillo]

/assign

[github-actions]

Thanks for taking this issue! Let us know if you have any questions!