Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cephfs: correct the id for cephfs locks #4731

Merged
merged 1 commit into from
Jul 25, 2024
Merged

cephfs: correct the id for cephfs locks #4731

merged 1 commit into from
Jul 25, 2024

Conversation

NymanRobin
Copy link
Contributor

@NymanRobin NymanRobin commented Jul 25, 2024 •
edited
Loading

There was a discrepancy between the objectId when creating the lock and when releasing the lock this causes every lock to hang.

Fixes: #4727

This removes the performance concerns discussed in this review thread, after this change the pods with this encrypted filesystems comes up in seconds as expected.

@mergify mergify bot added the component/cephfs Issues related to CephFS label Jul 25, 2024
Sunnatillo
Sunnatillo reviewed Jul 25, 2024
View reviewed changes
Copy link
Contributor

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sunnatillo
Copy link
Contributor

Thank you for taking care of it.

iPraveenParihar
iPraveenParihar previously approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@iPraveenParihar iPraveenParihar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

nixpanic
nixpanic previously approved these changes Jul 25, 2024
View reviewed changes
@nixpanic
Copy link
Member

@Mergifyio rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 25, 2024

rebase

❌ Pull request can't be updated with latest base branch changes

Mergify needs the author permission to update the base branch of the pull request.
@Nordix needs to authorize modification on its head branch.

@NymanRobin @Sunnatillo
cephfs: correct the id for cephfs locks
8e7d2d8 
There was a discrepancy between the objectId
when creating the lock and when releasing the lock
this caused every lock to hang.

Signed-off-by: NymanRobin <robin.nyman@est.tech>
@nixpanic nixpanic added the ok-to-test Label to trigger E2E tests label Jul 25, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@mergify mergify bot dismissed stale reviews from iPraveenParihar and nixpanic July 25, 2024 15:40

Pull request has been modified.

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Jul 25, 2024
@mergify mergify bot merged commit da6279b into ceph:devel Jul 25, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sunnatillo Sunnatillo Sunnatillo left review comments

@nixpanic nixpanic nixpanic approved these changes

@yati1998 yati1998 yati1998 approved these changes

@iPraveenParihar iPraveenParihar Awaiting requested review from iPraveenParihar

Assignees
No one assigned
Labels
component/cephfs Issues related to CephFS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve performance in encrypted cephfs provisioning
6 participants
@NymanRobin @Sunnatillo @nixpanic @ceph-csi-bot @yati1998 @iPraveenParihar