Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert code added to maintain cephfs mount cache on nodes #824

Closed
ShyamsundarR opened this issue Feb 9, 2020 · 6 comments
Closed

Revert code added to maintain cephfs mount cache on nodes #824

ShyamsundarR opened this issue Feb 9, 2020 · 6 comments

Comments

@ShyamsundarR
Copy link
Contributor

As functionality added by PR #282 for CephFS fuse mounts does not work as intended, from a code maintainability standpoint we should revert this commit or remove the added code.

@jianglingxia
Copy link

if the #282 PR reverted ,the ceph csi driver daemonset plugin existed,caused the pod mount path transport endpoint is not connected error problem can resolved? @ShyamsundarR
thanks

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Feb 10, 2020

it won't resolve any issue. this code is not working as expected am working on removing the code

@jianglingxia
Copy link

@Madhu-1 really thanks, i want to know that the transport endpoint is not connected error ,the problem is cephfs-fuse client reason? not csi driver reason is right?

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Feb 10, 2020

@jianglingxia see #703 (comment) for the more detailed explanation

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Feb 25, 2020

closing this one as #825 is merged

@Madhu-1 Madhu-1 closed this as completed Feb 25, 2020
@huaizong
Copy link

huaizong commented Apr 12, 2020

@ShyamsundarR @jianglingxia @Madhu-1 I feel sorry for patch not help, but as PR #282 describe, mount cache patch only work if Pod can restart when csi container exit, it may trigger by health probe check or other similar technology.

If Pod not check mount path, mount cache can not help in thhe scenarios.

NoGoal

Pod should exit and restart when csi plugin pod exit and mount point lost. if pod not exit will get error of transport endpoint is not connected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants