Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update CSI_UPGRADE_VERSION to v3.12.1 #4785

Merged
merged 1 commit into from
Aug 20, 2024
Merged

ci: update CSI_UPGRADE_VERSION to v3.12.1 #4785

merged 1 commit into from
Aug 20, 2024

Conversation

iPraveenParihar
Copy link
Contributor

@iPraveenParihar iPraveenParihar commented Aug 20, 2024 •
edited by nixpanic
Loading

Describe what this PR does

This commit updates CSI_UPGRADE_VERSION to latest

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Depends-on: #4783

Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)

@iPraveenParihar
ci: update CSI_UPGRADE_VERSION to v3.12.1
6dfb3ab 
Signed-off-by: Praveen M <m.praveen@ibm.com>
@iPraveenParihar iPraveenParihar self-assigned this Aug 20, 2024
@mergify mergify bot added the component/testing Additional test cases or CI work label Aug 20, 2024
@iPraveenParihar iPraveenParihar marked this pull request as ready for review August 20, 2024 09:16
@iPraveenParihar iPraveenParihar mentioned this pull request Aug 20, 2024
Merged
6 tasks
@iPraveenParihar
Copy link
Contributor Author

@Madhu-1, can we skip e2e?

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Aug 20, 2024

@Madhu-1, can we skip e2e?

@iPraveenParihar we need to run e2e to ensure upgrade passes

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Aug 20, 2024

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 20, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

Pull request #4785 has been dequeued by a dequeue command.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@iPraveenParihar
Copy link
Contributor Author

@Madhu-1, can we skip e2e?

@iPraveenParihar we need to run e2e to ensure upgrade passes

I thought of running just the upgrade test alone, instead of running all regular runs.

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Aug 20, 2024

@Madhu-1, can we skip e2e?

@iPraveenParihar we need to run e2e to ensure upgrade passes

I thought of running just the upgrade test alone, instead of running all regular runs.

Yes that is also fine, we can do that one

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Aug 20, 2024

@Mergifyio unqueue

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 20, 2024

unqueue

✅ The pull request has been removed from the queue default

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Aug 20, 2024

@iPraveenParihar run the upgrade manually and if all the required test passes, we can add skip label and add this to queue.

@iPraveenParihar
Copy link
Contributor Author

/test ci/centos/upgrade-tests-rbd

@iPraveenParihar
Copy link
Contributor Author

/test ci/centos/upgrade-tests-cephfs

@nixpanic
Copy link
Member

CI jobs failed with this:

  I0820 11:11:28.375162 80996 dump.go:53] At 2024-08-20 11:01:35 +0000 UTC - event for csi-rbdplugin-provisioner-b6bb4d8bb-9phtk: {kubelet minikube} BackOff: Back-off pulling image "quay.io/cephcsi/cephcsi:v3.12.1"

The image should be available now.

@nixpanic
Copy link
Member

/test ci/centos/upgrade-tests

@nixpanic nixpanic added ci/skip/e2e skip running e2e CI jobs ok-to-test Label to trigger E2E tests labels Aug 20, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.31

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Aug 20, 2024
@nixpanic
Copy link
Member

/test ci/centos/upgrade-tests

Both passed:

@nixpanic
Copy link
Member

@Mergifyio requeue

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 20, 2024

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify mergify bot merged commit 3570ac4 into ceph:devel Aug 20, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nixpanic nixpanic nixpanic approved these changes

@Madhu-1 Madhu-1 Madhu-1 approved these changes

@Rakshith-R Rakshith-R Awaiting requested review from Rakshith-R

Assignees

@iPraveenParihar iPraveenParihar

Labels
ci/skip/e2e skip running e2e CI jobs component/testing Additional test cases or CI work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iPraveenParihar @Madhu-1 @nixpanic @ceph-csi-bot