Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rados Striping API Support #1011

Closed
hd916162 opened this issue Jul 11, 2024 · 6 comments · Fixed by #1015
Closed

Rados Striping API Support #1011

hd916162 opened this issue Jul 11, 2024 · 6 comments · Fixed by #1015
Assignees

Comments

@hd916162
Copy link

hd916162 commented Jul 11, 2024

Will there be a support for radosstriping ?

Tasks

No tasks being tracked yet.
@anoopcs9
Copy link
Collaborator

Will there be a support for radosstriping ?

Can you specify the corresponding API from ceph?

@hd916162
Copy link
Author

API described here.
src/include/radosstriper/libradosstriper.hpp
These API are also avaiable in rados cli by specify flag --striper
image

@phlogistonjohn
Copy link
Collaborator

Thanks for the hint. I don't think the .hpp file would work for us as that is C++. But there's a src/include/radosstriper/libradosstriper.h that could possibly work. Please note that adding a whole new library of ceph bindings to go-ceph would be a lot of work and may not proceed quickly. Contributions and/or design discussion could speed up the process.

@phlogistonjohn
Copy link
Collaborator

I could see adding a new package like "rados/striper" and within it a wrapper type
Striper that encapsulates rados_striper_t. Then for example we could have methods on Striper for the rados_striper_set_object_layout* functions. And then methods like Read, Write, WriteFull, etc. that are similar to what we have in rados for an IOContext but for Striper instead.

How does that sound?

@phlogistonjohn
Copy link
Collaborator

I think we would skip implementing anything using rados_striper_multi_completion_t initially. That could be a separate future feature request once someone knows that it's really needed.

@phlogistonjohn
Copy link
Collaborator

The functions named in that screenshot for --striper option match exactly the functions that take a rados_striper_t in the libradosstriper.h header, FWIW.

@phlogistonjohn phlogistonjohn self-assigned this Jul 25, 2024
phlogistonjohn added a commit to phlogistonjohn/go-ceph that referenced this issue Jul 29, 2024
Start a new `rados/striper` package that wraps Ceph's libradosstriper.
The libradosstriper library builds on top of the librados library to
support striping large "objects" over multiple RADOS objects.

Fixes: ceph#1011

Signed-off-by: John Mulligan <jmulligan@redhat.com>
phlogistonjohn added a commit to phlogistonjohn/go-ceph that referenced this issue Jul 29, 2024
Start a new `rados/striper` package that wraps Ceph's libradosstriper.
The libradosstriper library builds on top of the librados library to
support striping large "objects" over multiple RADOS objects.

Fixes: ceph#1011

Signed-off-by: John Mulligan <jmulligan@redhat.com>
phlogistonjohn added a commit to phlogistonjohn/go-ceph that referenced this issue Jul 29, 2024
Start a new `rados/striper` package that wraps Ceph's libradosstriper.
The libradosstriper library builds on top of the librados library to
support striping large "objects" over multiple RADOS objects.

Fixes: ceph#1011

Signed-off-by: John Mulligan <jmulligan@redhat.com>
phlogistonjohn added a commit to phlogistonjohn/go-ceph that referenced this issue Aug 2, 2024
Start a new `rados/striper` package that wraps Ceph's libradosstriper.
The libradosstriper library builds on top of the librados library to
support striping large "objects" over multiple RADOS objects.

Fixes: ceph#1011

Signed-off-by: John Mulligan <jmulligan@redhat.com>
phlogistonjohn added a commit to phlogistonjohn/go-ceph that referenced this issue Aug 7, 2024
Start a new `rados/striper` package that wraps Ceph's libradosstriper.
The libradosstriper library builds on top of the librados library to
support striping large "objects" over multiple RADOS objects.

Fixes: ceph#1011

Signed-off-by: John Mulligan <jmulligan@redhat.com>
@mergify mergify bot closed this as completed in #1015 Aug 8, 2024
@mergify mergify bot closed this as completed in 33ed5ce Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants