services/kill: make username check case-insensitive #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kill route checks if github_username == run_owner (from paddles). Github returns username "JohnDoe" while run-names scheduled via teuthology machines have no captilzation like "johndoe". This results in error like: `ERROR:teuthology_api.services.kill:JohnDoe doesn't have permission to kill a job scheduled by: johndoe` Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kill route checks if github_username == run_owner (from paddles).
Github returns username like "JohnDoe" while run-names scheduled via teuthology machines have no capitalisation like "johndoe". This results in error like:
ERROR:teuthology_api.services.kill:JohnDoe doesn't have permission to kill a job scheduled by: johndoeRuns scheduled by teuthology-api would not have above error because they would have run-name capitalised too like "JohnDoe-2024-01-08_10:32:53-teuthology:no-ceph-main-distro-default-testnode".
Contribution Guidelines
To sign and test your commits, please refer to Contibution guidelines.
Checklist