Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support gasPrice field on dynamicFee transactions #80

Closed
i-norden opened this issue Jul 9, 2021 · 2 comments · Fixed by #247
Closed

Support gasPrice field on dynamicFee transactions #80

i-norden opened this issue Jul 9, 2021 · 2 comments · Fixed by #247
Assignees

Comments

@i-norden
Copy link
Collaborator

i-norden commented Jul 9, 2021

ethereum/execution-specs#251

@i-norden i-norden changed the title Support gasPrice field on dynamicFeeTxs Support gasPrice field on dynamicFee transactions Jul 9, 2021
@i-norden
Copy link
Collaborator Author

@dboreham @AFDudley pinging since this issue has been buried but is still needed to perfectly replicate the geth eth json rpc api.

We already set gasPrice to effectiveGasPrice for a mined transaction

result.GasPrice = (*hexutil.Big)(price)

For an un-mined tx we should adjust so that "If the transaction has not yet been mined, clients should return the maxFeeCapPerGas value as gasPrice". This isn't an issue for us now as we don't have un-mined transactions until we merge the probe database.

@AFDudley
Copy link
Contributor

@telackey Please close this if it's been resolved in v5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants