Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update getLogs to work with new log_cids table #87

Closed
i-norden opened this issue Aug 10, 2021 · 1 comment · Fixed by #92
Closed

Update getLogs to work with new log_cids table #87

i-norden opened this issue Aug 10, 2021 · 1 comment · Fixed by #92

Comments

@i-norden
Copy link
Collaborator

i-norden commented Aug 10, 2021 •
edited
Loading

For both RPC and GQL
@arijitAD arijitAD mentioned this issue Aug 16, 2021
Merged
@ashwinphatak
Copy link
Collaborator

As part of this, apart from returning log cid + ipld block instead of receipt_cid + ipld block, we should also return the 'status' from the receipt, which downstream clients can use to decide if that log should be processed.

@ashwinphatak ashwinphatak mentioned this issue Aug 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix getLog API to use log_cids table cerc-io/ipld-eth-server
2 participants
@ashwinphatak @i-norden