Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(settings): options component is broken. #626

Closed
dubisdev opened this issue Nov 14, 2022 · 0 comments · Fixed by #627
Closed

fix(settings): options component is broken. #626

dubisdev opened this issue Nov 14, 2022 · 0 comments · Fixed by #627

Comments

@dubisdev
Copy link
Contributor

  • OS version and name: All OS
  • Cerebro.app version: Cerebro v0.9.0

Issue

The option component in the Settings API is broken. Users can set it but it is not saved. This is caused by the new API in react-select. Now the value isn't just a string, it is an Object containing {value, label}, we must handle this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fix plugin settings cerebroapp/cerebro
1 participant
@dubisdev