Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop graphql-upload #42

Closed
cerinoligutom opened this issue Jun 27, 2022 · 0 comments · Fixed by #43
Closed

Drop graphql-upload #42

cerinoligutom opened this issue Jun 27, 2022 · 0 comments · Fixed by #43
Assignees

Comments

@cerinoligutom
Copy link
Owner

cerinoligutom commented Jun 27, 2022

The upload feature via the GraphQL layer demonstrated currently in this boilerplate is really just to show an example that it is possible to do it via GraphQL. However, there have have been people using this boilerplate for their production apps reaching out to me and asking clarifications regarding how to handle file uploads at scale which in any case, I always end up recommending not to use graphql-upload if they have plans to scale. Apollo has a blog post about the topic and I highly recommend you to read it and go with Option 1 or 2 described there.

This boilerplate currently uses Option 3 which is not recommended. The original motivation for having this in the boilerplate was to show a working code for a file upload feature applied on a layered architecture with an opinionated folder structure along with GraphQL Code Generator. See singleUpload and multipleUpload mutations.

With that said, I'll be dropping the file upload feature and link the blog post as a tip instead. I won't be adding an opinionated way of handling file uploads as that is dependent on the implementation details of the 3rd party service and I don't want to lock this boilerplate to a specific service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant