diff --git a/README.md b/README.md index 72bf6d4..42e089c 100644 --- a/README.md +++ b/README.md @@ -72,7 +72,9 @@ To test the plugins, you need to run the following command: $ npm run dev ``` -Go to `http://localhost:8090/?id=test-video` to test the plugins. +Go to `http://localhost:8090/?id=test-video` to test the plugins. You will maybe need to chnages parameters in the url to test the plugins. + +For example to test the **nextTimeButtonPlugin** and the **prevTimeButtonPlugin**, you need to add the following parameters to the url: `&time=3m,4m,5m`. --- diff --git a/package.json b/package.json index 9db17e8..ea98bdc 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@cern-vc/cern-paella-plugins", - "version": "0.2.2", + "version": "0.2.3", "description": "Paella plugins for cern use", "main": "src/index.js", "module": "dist/cern-paella-plugins.js", diff --git a/src/plugins/ch.cern.paella.nextTimeButtonPlugin.js b/src/plugins/ch.cern.paella.nextTimeButtonPlugin.js index 35b6c1b..3baa4a3 100644 --- a/src/plugins/ch.cern.paella.nextTimeButtonPlugin.js +++ b/src/plugins/ch.cern.paella.nextTimeButtonPlugin.js @@ -55,13 +55,13 @@ export default class NextTimeButtonPlugin extends ButtonPlugin { const addSuffix = this.config.suffix !== undefined ? this.config.suffix : true; this.suffix = addSuffix ? "s" : ""; - this.icon = ``; + this.icon = defaultForwardIcon; setTimeout(() => { Array.from(this.iconElement.getElementsByClassName("time-text")).forEach( (textIcon) => { // eslint-disable-next-line no-param-reassign textIcon.innerHTML = this.time + this.suffix; - }, + } ); }, 100); } @@ -74,7 +74,7 @@ export default class NextTimeButtonPlugin extends ButtonPlugin { } this.time = this.slots[this.player.currentPosition]; console.log( - `Jump to next time: ${this.time}. Slot ${this.player.currentPosition}`, + `Jump to next time: ${this.time}. Slot ${this.player.currentPosition}` ); // const currentTime = await this.player.videoContainer.currentTime(); this.player.videoContainer.setCurrentTime(this.time); diff --git a/src/plugins/ch.cern.paella.prevTimeButtonPlugin.js b/src/plugins/ch.cern.paella.prevTimeButtonPlugin.js index 7616fc2..0bc7468 100644 --- a/src/plugins/ch.cern.paella.prevTimeButtonPlugin.js +++ b/src/plugins/ch.cern.paella.prevTimeButtonPlugin.js @@ -1,5 +1,5 @@ import { ButtonPlugin } from "paella-core"; -import defaultIcon from "./icons/previous-icon.svg"; +import defaultBackwardIcon from "./icons/previous-icon.svg"; const params = new Proxy(new URLSearchParams(window.location.search), { get: (searchParams, prop) => searchParams.get(prop), @@ -56,13 +56,13 @@ export default class PrevTimeButtonPlugin extends ButtonPlugin { const addSuffix = this.config.suffix !== undefined ? this.config.suffix : true; this.suffix = addSuffix ? "s" : ""; - this.icon = ``; + this.icon = defaultBackwardIcon; setTimeout(() => { Array.from(this.iconElement.getElementsByClassName("time-text")).forEach( (textIcon) => { // eslint-disable-next-line no-param-reassign textIcon.innerHTML = this.time + this.suffix; - }, + } ); }, 100); } @@ -75,7 +75,7 @@ export default class PrevTimeButtonPlugin extends ButtonPlugin { } this.time = this.slots[this.player.currentPosition]; console.log( - `Jump to previous time: ${this.time}. Slot ${this.player.currentPosition}`, + `Jump to previous time: ${this.time}. Slot ${this.player.currentPosition}` ); this.player.videoContainer.setCurrentTime(this.time); }