Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unifying cmctl and kubectl cert-manager #38

Closed
inteon opened this issue Mar 18, 2024 · 0 comments · Fixed by #61
Closed

Unifying cmctl and kubectl cert-manager #38

inteon opened this issue Mar 18, 2024 · 0 comments · Fixed by #61
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.

Comments

@inteon
Copy link
Member

inteon commented Mar 18, 2024

Currently, we release two binaries cmctl and kubectl_cert-manager.
This was introduced in cert-manager/cert-manager#4522.
However, instead of using build-time variables to determine the binary name, we could determine the binary name at runtime (see https://krew.sigs.k8s.io/docs/developer-guide/develop/best-practices/).
That would allow us to simplify the releases, we could then only release a single binary.
@inteon inteon added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Apr 5, 2024
@inteon inteon mentioned this issue Apr 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make the binary dynamically determine whether it is a kubectl plugin inteon/cmctl
1 participant
@inteon