Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github release tag convention does not match python/pip version tags (2022.12.07 GH vs 2022.12.7 pip) #220

Closed
danekantner opened this issue Mar 14, 2023 · 4 comments

Comments

@danekantner
Copy link

github release tag convention does not match python/pip version tags, the GitHub scheme being used fills in single digit date fields with a prepended 0, but the Python version scheme does not (2022.12.07 vs 2022.12.7)

This is causing many tools that assess versions to have the incorrect information. This is particularly relevant and problematic because Github has originated CVE-2022-23491 stating impacted versions using the Github release tags 2012.12.07, but the package that actually gets deployed will always report out to be version 2022.12.7 based on the python/pip version scheme.

The Github release tags should match what is reported in the actual Python/Pip package metadata that is built from the same release.

@danekantner
Copy link
Author

The naming convention of pypi to drop the 0 from dates (in python wheel setup tools) seems to have been firmly established when this issue was closed by modifying documentation to remove the 0 instead of changing the behavior of how it works: pypa/setuptools#302

@danekantner
Copy link
Author

This was previously discussed in #208 but closed without resolution

@sigmavirus24
Copy link
Member

There is no resolution to be had. We have a clear and standard versioning scheme. Parts of python's packaging ecosystem normalize names in a way that's well documented and reusable as a library. If people claiming integration with Python aren't normalizing things themselves, they aren't doing a good job of integrating. If you're paying them, demand they do better because you're not getting what you paid for.

It's not imperative that we satisfy inaction on the part of companies lying about their support of this language's ecosystem.

@sigmavirus24 sigmavirus24 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 14, 2023
@danekantner
Copy link
Author

For some tools this may resolve itself shortly -- NIST has updated the CVE definition to match the version scheme used in the built artifacts/python

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants