-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GrowthMaps#dev? #48
Comments
There is no dev branch, I don't think much needs to change here except bumping some compat versions? You are allowed to do that too, and make a PR :) just Check you can install the latest Rasters, run the tests, push, PR. I can't imagine when I will personally have a spare hour to do that. |
Great, thank you! I'll try my best. Very new to Julia but happy to help :) |
Ahh right, maybe thats a big ask then. You found a pretty obscure package to start with! I will try to bump these deps but I'm afraid the tests wont pass, even though the package will probably work. |
Yes, I've already done it and tests don't pass, I don't mind giving it a look and look for the incompatibilities til you find time. It's good practice :) |
Hey there, Don't know if a PR is the best way to tackle this so I first leave a comment here. I've checked the incompatibility issues and I've reached the following loop. Let me know how you wanna tackle this and feel no rush, I'm interested in a couple of functionalities of the package but it's not a life or death thing. Ps: Tests don't pass either now, but I think it's due to old Rasters.jl syntax so should be quite easy to fix. Good weekend, |
Maybe try just with those packages in a new clean environment without GrowthMaps.jl? (Not your default environment with packages in it) Those packages should work together, if not you will need to fix their compat directly, it's not something I can fix here. |
True! You're right :) |
Hey again,
Assuming you have other priorities before updating this package, is there a chance there's an available GrowthMaps#dev branch that is compatible with current versions of Rasters.jl, DD, etc?
Thanks,
Nico
The text was updated successfully, but these errors were encountered: