Install packaging first separately #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the new pre-commit thingy didn't run here, maybe it needs to be merged first but I'll try separately if I can |
|
ok I got it to run there: Theodlz#3, but didn't work as expected I think. Changed a lot of imports that the previous pre-commit GA or the local version wouldn't have. Not sure their CI think is working as intended. |
Theodlz
force-pushed
the
fix-packaging
branch
from
57cc738 to
e888a4d
Compare
|
removed the pre-commit changes |
Theodlz
force-pushed
the
fix-packaging
branch
from
e888a4d to
f81f19c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt/suggestion to fix #374
ALSO: we try migrating to pre-commit.ci now that the pre-commit github action is deprecated.