From 0534a9c8df2d1f6e29999046f70a8e705f779f47 Mon Sep 17 00:00:00 2001 From: lepadatu Date: Mon, 31 Dec 2018 17:32:23 +0200 Subject: [PATCH] Update provider.yml provider_arn is not needed at every single event type, but only for update and delete. Lambda execution is billable. --- provider.yml | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/provider.yml b/provider.yml index 9bf5348..f6f889d 100644 --- a/provider.yml +++ b/provider.yml @@ -68,16 +68,17 @@ Resources: def lambda_handler(event, context): provider_xml = event['ResourceProperties']['Metadata'] provider_name = event['ResourceProperties']['Name'] - # create a default ARN from the name; will be overwritten if we are creating - provider_arn = "arn:aws:iam::${AWS::AccountId}:saml-provider/" + provider_name if event['RequestType'] == 'Create': res, provider_arn = create_provider(provider_name, provider_xml) reason = "Creation succeeded" - elif event['RequestType'] == 'Update': - res, reason = update_provider(provider_arn, provider_xml) - elif event['RequestType'] == 'Delete': - res, reason = delete_provider(provider_arn) + elif (event['RequestType'] == 'Update') or (event['RequestType'] == 'Delete'): + # create a default ARN from the name + provider_arn = "arn:aws:iam::${AWS::AccountId}:saml-provider/" + provider_name + if event['RequestType'] == 'Update': + res, reason = update_provider(provider_arn, provider_xml) + elif event['RequestType'] == 'Delete': + res, reason = delete_provider(provider_arn) else: res = False resp = "Unknown operation: " + event['RequestType']