Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary dimensions on some examples #272

Closed
cofinoa opened this issue May 29, 2020 · 2 comments · Fixed by #268
Closed

Unnecessary dimensions on some examples #272

cofinoa opened this issue May 29, 2020 · 2 comments · Fixed by #268
Labels
defect Conventions text meaning not as intended, misleading, unclear, has typos, format or language errors

Comments

@cofinoa
Copy link
Contributor

cofinoa commented May 29, 2020

Title

Unnecessary dimensions on some examples.

Moderator

@JonathanGregory

Requirement

SummaryIn some examples where only string type is been used, there is a dimension name_strlen which it's unnecesary.

Technical Proposal Summary

Remove them

Benefits

Less confusing

Status Quo

Discussion of the current state CF and other standards.

Detailed Proposal

Those unnecessary dimensions has been removed in the PR #268

@cofinoa cofinoa added the defect Conventions text meaning not as intended, misleading, unclear, has typos, format or language errors label May 29, 2020
@JonathanGregory
Copy link
Contributor

Thanks for opening this issue. As I said in #268, the changes look fine to me. The dimensions are unnecessary because the examples concerned have been changed from character arrays to strings. They are all in Appendix H.
This is a defect issue because it doesn't materially change the convention. It simply corrects the document. It will be approved by default if no-one objects within three weeks.

@JonathanGregory
Copy link
Contributor

I have merged the pull request. Thanks for making this correction, Antonio @cofinoa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Conventions text meaning not as intended, misleading, unclear, has typos, format or language errors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants