-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Headers instead of section divs #97
Comments
This would fundamentally change the way the script works today. The last version had a set up kind of like this, and it was fraught with an accuracy. I can see the appeal, but I’m worried about implementation |
Looking at how other jQuery dependent scripts do this, I think you’re right. I’ll see if I can make this happen. |
@cferdinandi Great! I don't think it's that hard -- you just need to test for In case it's helpful, here's some code I wrote to do this recently (but based on jQuery). That project is hoping to replace this code with Gumshoe. |
Alright, just added support for this with v5.1.0: https://github.com/cferdinandi/gumshoe/releases/tag/v5.1.0 |
Have you considered supporting the use-case of headers (like
<h1>
,<h2>
, etc.) implicitly defining sections (the interval between one header inclusive and the next header exclusive), instead of explicit section<div>
s? This seems like a common use-case, e.g., the output of various Markdown translators, and is presumably addable via an option. If there's interest, I may be able to contribute a PR.The text was updated successfully, but these errors were encountered: