Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AlertFieldLevel] Vertically centering text, 5px margin between icon and text #276

Open
shindigira opened this issue Jan 11, 2024 · 1 comment · May be fixed by #278
Open

[AlertFieldLevel] Vertically centering text, 5px margin between icon and text #276

shindigira opened this issue Jan 11, 2024 · 1 comment · May be fixed by #278
Assignees
Labels
enhancement New feature or request

Comments

@shindigira
Copy link
Contributor

shindigira commented Jan 11, 2024

Delayed

Requires a DS change first.

@billhimmelsbach
Copy link
Contributor

Heyo @shindigira! I know you're still working on this, but just wanted to let you know that after today's discussions, these three TODOs are going to be fixed at the source in the DS first instead of in the DSR in this PR:

  • Change Margin between icon and text to 5px in AlertFieldLevel
  • fix the centering icon in Alert (not fieldlevel) (Delay LOW PRIORITY: [context](figma comment that we will revisit this change later))
  • Error dotted line around checkbox/textinput

The first two of those TODOs (the margin and centering the icon) will also be de-prioritized and moved to the backlog for now too. Should make this PR a little smaller! 🤞

@shindigira shindigira changed the title [AlertFieldLevel] Vertically centering text, 8px margin between icon and text [AlertFieldLevel] Vertically centering text, 5px margin between icon and text Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants