Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Styling Issues] Landing pages #315

Open
6 tasks
meissadia opened this issue Mar 19, 2024 · 3 comments
Open
6 tasks

[Styling Issues] Landing pages #315

meissadia opened this issue Mar 19, 2024 · 3 comments
Assignees
Labels
post-mvp to be done after MVP deadline triage tickets that need investigation to be updated or closed

Comments

@meissadia
Copy link
Collaborator

meissadia commented Mar 19, 2024

Issues

How it is How it should be
Image Image

Pages

  • Authenticated landing
  • Unauthenticated landing

Todo

  • Review DSR components and verify their implementation aligns with DS
  • Review SBL pages and verify their structure aligns with CF Auto loans
  • Remove additional borders/padding/margins applied only in SBL
  • Confirm content alignment
@meissadia meissadia self-assigned this Mar 19, 2024
@meissadia meissadia added the post-mvp to be done after MVP deadline label May 16, 2024
@billhimmelsbach
Copy link
Contributor

I think this is completed, but maybe worth checking.

@billhimmelsbach billhimmelsbach added the triage tickets that need investigation to be updated or closed label Sep 10, 2024
@natalia-fitzgerald
Copy link

@meissadia
I don't think this is completed but I will add it to my list of things to check after I am able to review the responsive navigation.

@natalia-fitzgerald
Copy link

I think that this issue I just created is related: #1033
There I list out the alignment issues with the desktop navigation and header space.

But there is more:
Here, there is an extra 8px of space that is preventing left alignment:
Screenshot 2024-10-29 at 1 47 11 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
post-mvp to be done after MVP deadline triage tickets that need investigation to be updated or closed
Projects
None yet
Development

No branches or pull requests

3 participants