Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

model_t refactoring?! #111

Open
johannesugb opened this issue Aug 18, 2021 · 0 comments
Open

model_t refactoring?! #111

johannesugb opened this issue Aug 18, 2021 · 0 comments
Labels
C++ C++-centric task enhancement New feature or request

Comments

@johannesugb
Copy link
Member

Evaluate model_t w.r.t. the following points:

  • Does model_t have to be a resource? Collection of plain data arrays
  • model_t should not create buffers from per-vertex data - reduces coupling
  • load_from_file() should not be a method of model_t? - single responsibility principle

Once evaluated, further steps are to be discussed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C++ C++-centric task enhancement New feature or request
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johannesugb