From 66bdc8bca918ff953ae60fdece356732ad3fcb0a Mon Sep 17 00:00:00 2001 From: "Alexander M. Turek" Date: Wed, 28 Jun 2023 11:52:05 +0200 Subject: [PATCH 1/2] Fix binding unused parameter (#6072) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit | Q | A |------------- | ----------- | Type | bug | Fixed issues | #5816 #### Summary `SQLServerSchemaManager::selectTableNames()` binds a parameter that does not exist in the query. I don't know how we can make the CI catch this issue. This piece is covered by a test that fails on my machine, but apparently the SQL Server and driver setup that I use locally is more picky about extra parameter than the one we use on GitHub actions. 🤷🏻 --- src/Schema/SQLServerSchemaManager.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Schema/SQLServerSchemaManager.php b/src/Schema/SQLServerSchemaManager.php index 69e328fea0d..f717593af31 100644 --- a/src/Schema/SQLServerSchemaManager.php +++ b/src/Schema/SQLServerSchemaManager.php @@ -403,7 +403,7 @@ protected function selectTableNames(string $databaseName): Result ORDER BY name SQL; - return $this->_conn->executeQuery($sql, [$databaseName]); + return $this->_conn->executeQuery($sql); } protected function selectTableColumns(string $databaseName, ?string $tableName = null): Result From f5550bb91d2fc3ac4cbcf9207ef2f1b15cfb3aa2 Mon Sep 17 00:00:00 2001 From: "Alexander M. Turek" Date: Wed, 28 Jun 2023 12:02:14 +0200 Subject: [PATCH 2/2] PHPStan 1.10.21, PHPUnit 9.6.9, JetBrains Stubs 2023.1 (#6073) --- composer.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/composer.json b/composer.json index 3b145ea52d7..48438b07c0c 100644 --- a/composer.json +++ b/composer.json @@ -42,10 +42,10 @@ "require-dev": { "doctrine/coding-standard": "12.0.0", "fig/log-test": "^1", - "jetbrains/phpstorm-stubs": "2022.3", - "phpstan/phpstan": "1.10.14", + "jetbrains/phpstorm-stubs": "2023.1", + "phpstan/phpstan": "1.10.21", "phpstan/phpstan-strict-rules": "^1.5", - "phpunit/phpunit": "9.6.7", + "phpunit/phpunit": "9.6.9", "psalm/plugin-phpunit": "0.18.4", "squizlabs/php_codesniffer": "3.7.2", "symfony/cache": "^5.4|^6.0",