Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JOSE] Badges issue #13

Closed
BenjMy opened this issue Dec 19, 2022 · 3 comments
Closed

[JOSE] Badges issue #13

BenjMy opened this issue Dec 19, 2022 · 3 comments

Comments

@BenjMy
Copy link

BenjMy commented Dec 19, 2022

xref openjournals/jose-reviews#185

In the README file, I would expect the badges to link with the proper target i.e.:

  • conda forge -> to the conda gemgis forge repo
  • pypy -> to the pypy gemgis repo
  • (Check also license and doc)
@AlexanderJuestel
Copy link
Collaborator

Hello @BenjMy,

thanks for opening this issue. Does your issue imply that you would make the gemgis_data repo available on Pypi and via conda forge? As this repo only consists of tutorial materials, we have not considered adding a Pypi and conda forge solution yet.

What is your take on that?

BenjMy added a commit to BenjMy/gemgis_data that referenced this issue Jan 11, 2023
Prepare PR relative to cgre-aachen#13
@BenjMy
Copy link
Author

BenjMy commented Jan 11, 2023

Hello Alex,

As I'm not sure I made myself clear (sorry for that), I propose this issue be solved after reviewing the opened PR #22 😉

Initially, I did not mean to make the gemgis_data repo available on Pypi but I've seen you create one. After all, I think it might be relevant if you want to use gemgis-data as a package to fetch and prepare the data (with Pooch for instance) and keep dependencies out of gemgis core.

Please fell free to close the issue when the PR is solved!

@AlexanderJuestel
Copy link
Collaborator

Yeah, somehow, one was created but since there is no code in the repo and only data the previous question came up. But then I will continue working without having in mind to publish the gemgis_data repo on PyPi and fix the installation of gemgis with pip in the other issue and continue then with revising the remaining open tasks for me.

Thanks for the clarification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants