Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Delay implementation for qingke v4 #27

Open
romainreignier opened this issue Jun 13, 2024 · 1 comment · May be fixed by #28
Open

Add Delay implementation for qingke v4 #27

romainreignier opened this issue Jun 13, 2024 · 1 comment · May be fixed by #28

Comments

@romainreignier
Copy link
Contributor

I have made a draft PR on ch32-hal-template ch32-rs/ch32-hal-template#1 to add the option to not use embassy on the generated template but we would need a Delay implementation for qingke v4.

One could use this:

qingke::riscv::asm::delay(10_000_000);

for a template for beginners, I find that a real delay in milliseconds is easier to use.

@andelf
Copy link
Contributor

andelf commented Jun 13, 2024

Agreed.
A delay implementation is necessary when embassy is not enabled.

WCH's MCU is slow when running on FLASH. So the delay might be incorrect due to flash latency.

@romainreignier romainreignier linked a pull request Jun 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants