Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reject jQuery >= 3.0.0 #121

Closed
mgol opened this issue Aug 24, 2015 · 5 comments
Closed

Don't reject jQuery >= 3.0.0 #121

mgol opened this issue Aug 24, 2015 · 5 comments

Comments

@mgol
Copy link
Contributor

mgol commented Aug 24, 2015

jQuery 3.0 & jQuery Compat 3.0 promises will be Promises/A+-compliant (current master & 3.0.0-alpha1 pass the whole promises-aplus-tests@2.1.0 suite, we have it enforced in CI) so it'd be good if Chai as Promised didn't reject them.

jQuery 3.0 adds catch (defined as fn => promise.then(null, fn)) to its promises so it should be enough to modify this check; if thenable.catch exists, the promise should be fine.

Please let us know if there are still some problems that would prevent you to consume jQuery Promises. You can test on jquery@beta.

@mgol mgol changed the title Don't rejest jQuery >= 3.0.0 Don't reject jQuery >= 3.0.0 Aug 24, 2015
@keithamus
Copy link
Member

@mzgol would it be too cheeky to request a PR fixing this? I understand if your plate is full but it seems like it'd be a good idea as you have the best grasp of the issue.

@mgol
Copy link
Contributor Author

mgol commented Aug 24, 2015

Sure, I can submit a PR. I just wanted to get some feedback first. :)

@domenic
Copy link
Collaborator

domenic commented Aug 24, 2015

Yeah, seems good. Probably also want to modify the error message a bit later.

@mgol
Copy link
Contributor Author

mgol commented Aug 25, 2015

WIP PR: #122. I need some help with it (3 tests are failing).

@domenic
Copy link
Collaborator

domenic commented Mar 20, 2016

Fixed in v5.3.0.

@domenic domenic closed this as completed Mar 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants