Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requesting version bump #146

Closed
Alloyed opened this issue Sep 2, 2021 · 4 comments
Closed

Requesting version bump #146

Alloyed opened this issue Sep 2, 2021 · 4 comments

Comments

@Alloyed
Copy link

Alloyed commented Sep 2, 2021

Hi, I'm trying to use chai 4.3.4 in an environment that is neither node.js or the browser, and it works fine except for the fact that the polyfill to detect the global object as of type-detect 4.0.5 does not work in my environment (global does not exist, and neither does self, but globalThis does). Recent changes in #142 would absolutely work for my case, but there's no npm package right now that would pick them up.

Could type-detect and Chai get version bumps with these recent changes? thank you

@keithamus
Copy link
Member

Hey @Alloyed thanks for the issue!

Would you like to make a PR bumping the version? I'll merge it and release it and we can look to update Chai too!

@mstoykov
Copy link

I would really appreciate if a new version is released.

Looking around there doesn't seem to be a version number to be bumped and given #147 it seems like the way to release a version has been lost in the transition.

As an outside contributor it seems there is no action I can take in order to help the release, except for asking in issues at this time.

If there is something that can be done, please give some pointers and I can try to add it back to the CI, but it seems in the end someone will need to tag a release. Which isn't going to be doable by an outside contributor

@43081j
Copy link

43081j commented Jul 22, 2024

We probably just do them through GitHub releases now

Maybe @koddsson can help? (I'm still out travelling so not of much help yet)

@koddsson
Copy link
Member

I just cut chai@4.5.0. Feel free to comment or reopen if something is still wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants