Replies: 1 comment
-
A quick google search turned up this: |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Not sure if this is documented anywhere, but what qualifies a log to be an error instead of a warning?
For example:
[WARN] E5 chainflip_engine::multisig::client::ceremony_manager - Keygen ceremony failed: Insufficient messages received in broadcast of initial commitments
This log is only a warning, but it is a pretty serious failure.
After a quick discussion with @msgmaxim, we came to the conclusion that the log should only be
error
if:So by that definition, the above log message is correctly implemented as a warning because there is probably nothing the user can do about it.
There was once talk of @AlastairHolmes creating a logging document, maybe this document standardize the use of logging levels?
Beta Was this translation helpful? Give feedback.
All reactions