fix: dot decode xt #3904
Merged
fix: dot decode xt #3904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@martin-chainflip to be cherry-picked |
AlastairHolmes
approved these changes
Aug 28, 2023
martin-chainflip
approved these changes
Aug 28, 2023
Codecov Report
@@ Coverage Diff @@
## main #3904 +/- ##
=====================================
Coverage 71% 71%
=====================================
Files 365 365
Lines 56568 56649 +81
Branches 56568 56649 +81
=====================================
+ Hits 40365 40451 +86
+ Misses 14207 14188 -19
- Partials 1996 2010 +14
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AlastairHolmes
approved these changes
Aug 28, 2023
martin-chainflip
pushed a commit
that referenced
this pull request
Aug 28, 2023
* fix: dot decode xt * test: add decoding extrinsic tests
syan095
added a commit
that referenced
this pull request
Aug 29, 2023
…on-integration * origin/main: (43 commits) fix: dot decode xt (#3904) Initial Prometheus Integration into Engine (#3861) test: lag safety (#3903) Feat/deposit-tracking (#3889) task scope logging :) (#3901) doc: metadata fetching (#3900) fix: strictly monotonic (#3899) Chore/bouncer check source address (#3893) fix: index and hash log (#3898) fix: start ARB network and increase polkadot rpc connection limit 🐛🚀 (#3897) test: use Rich test externality for pallet mocks (#3874) fix: correct rotation transitions on failure (#3875) cherry-pick: localnet initial state fixes (#3892) fix block number reported for initial polkadot vault creation (#3891) chore: update polkadot to v1.0.0 (#3890) feat: add an optional limit to retrier requests (#3881) doc: next or pending (#3885) Chore/fix bouncer ccm (#3888) Feature: Runtime upgrade can require CFE version (#3880) feat: redemption executor (#3877) ... # Conflicts: # state-chain/cf-integration-tests/src/authorities.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
It seems there were some subtler encoding/decoding changes in the substrate upgrade and this particular one wasn't caught by the compiler since
encode()just returns a Vec<> again... but it adds 2 bytes to the front for the length - which caused us to fail the decoding.