Feature: Add dry run CLI and use it in register_account_role #3992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dry runs a runtime call Added a new dry run CLI function, which takes a RuntimeCall and returns the result. Register account role will now do a dry run and return immediately if it runs into an error
PRO-807 Check account role before registering
In the LP Api, when we call If the role is already set, we should return an error with either "already registered as {account_role}". |
|
The code compiles, but I'm not sure what would be the best approach to test this. All info are welcome |
Codecov Report
@@ Coverage Diff @@
## main #3992 +/- ##
=====================================
- Coverage 72% 72% -0%
=====================================
Files 367 367
Lines 58062 58081 +19
Branches 58062 58081 +19
=====================================
- Hits 42028 42024 -4
- Misses 13935 13955 +20
- Partials 2099 2102 +3
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dandanlen
reviewed
Sep 15, 2023
There was a problem hiding this comment.
@AlastairHolmes do you have any objections to adding this extension to the BaseRpcClient? Does this seem like the right approach?
dandanlen
approved these changes
Sep 19, 2023
dandanlen
pushed a commit
that referenced
this pull request
Sep 21, 2023
dandanlen
pushed a commit
that referenced
this pull request
Sep 28, 2023
dandanlen
pushed a commit
that referenced
this pull request
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-807
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Added a "dry run" CLI call that calls the substrate rpc, which dry runs a runtime call and returns the result.
Register account role will now do a dry run and return immediately if it runs into an error