Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add expiry block to liquidity channel event #4111

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

acdibble
Copy link
Contributor

Pull Request

Closes: PRO-xxx

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have updated documentation where appropriate.

Summary

Please include a succinct description of the purpose and content of the PR. What problem does it solve, and how? Link issues, discussions, other PRs, and anything else that will help the reviewer.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #4111 (d711447) into main (c7e75b7) will increase coverage by 0%.
Report is 7 commits behind head on main.
The diff coverage is 83%.

@@          Coverage Diff          @@
##            main   #4111   +/-   ##
=====================================
  Coverage     71%     71%           
=====================================
  Files        377     377           
  Lines      60034   60086   +52     
  Branches   60034   60086   +52     
=====================================
+ Hits       42744   42819   +75     
+ Misses     15044   15022   -22     
+ Partials    2246    2245    -1     
Files Coverage Δ
state-chain/pallets/cf-ingress-egress/src/lib.rs 85% <100%> (+<1%) ⬆️
state-chain/pallets/cf-ingress-egress/src/mock.rs 98% <100%> (ø)
state-chain/pallets/cf-ingress-egress/src/tests.rs 99% <100%> (ø)
state-chain/traits/src/lib.rs 49% <ø> (ø)
state-chain/traits/src/mocks/deposit_handler.rs 84% <100%> (+1%) ⬆️
state-chain/pallets/cf-lp/src/lib.rs 69% <67%> (-1%) ⬇️
state-chain/runtime/src/chainflip.rs 53% <0%> (ø)

... and 24 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@acdibble acdibble requested review from dandanlen and kylezs October 12, 2023 09:57
@acdibble acdibble merged commit 1176671 into main Oct 12, 2023
@acdibble acdibble deleted the feat/add-expiry-to-liquidity branch October 12, 2023 12:44
syan095 added a commit that referenced this pull request Oct 12, 2023
* origin/main:
  Feat: Set pool fees (#4050)
  fix: don't egress empty all_batch calls (#4102)
  fix: don't abort broadcast if signers are unavailable (#4104)
  feat: add restricted balances to AccountInfoV2 (#4048)
  feat: use snake case for lp api method names (#4108)
  feat: add expiry block to liquidity channel event (#4111)

# Conflicts:
#	state-chain/custom-rpc/src/lib.rs
#	state-chain/runtime/src/lib.rs
#	state-chain/runtime/src/runtime_apis.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants