Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace latest_finalized_hash with latest_finalized_header #4206

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

AlastairHolmes
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #4206 (10b0a99) into main (f6981d6) will increase coverage by 0%.
The diff coverage is 26%.

@@          Coverage Diff          @@
##            main   #4206   +/-   ##
=====================================
  Coverage     72%     72%           
=====================================
  Files        383     383           
  Lines      62348   62311   -37     
  Branches   62348   62311   -37     
=====================================
- Hits       44637   44631    -6     
+ Misses     15376   15344   -32     
- Partials    2335    2336    +1     
Files Coverage Δ
...gine/src/state_chain_observer/sc_observer/tests.rs 88% <100%> (-<1%) ⬇️
engine/src/state_chain_observer/test_helpers.rs 100% <100%> (ø)
...chain_source/chunked_by_vault/deposit_addresses.rs 0% <0%> (ø)
...nked_chain_source/chunked_by_vault/egress_items.rs 0% <0%> (ø)
...tate_chain_observer/client/extrinsic_api/signed.rs 0% <0%> (ø)
engine/src/state_chain_observer/sc_observer/mod.rs 37% <29%> (ø)
engine/src/witness/eth.rs 0% <0%> (ø)
api/lib/src/queries.rs 20% <0%> (ø)
engine/src/witness/common/epoch_source.rs 0% <0%> (ø)
engine/src/state_chain_observer/client/mod.rs 24% <27%> (+1%) ⬆️

... and 5 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@AlastairHolmes AlastairHolmes marked this pull request as draft November 7, 2023 09:27
@AlastairHolmes AlastairHolmes removed the request for review from kylezs November 7, 2023 09:27
@AlastairHolmes AlastairHolmes marked this pull request as ready for review November 7, 2023 13:01
@AlastairHolmes AlastairHolmes merged commit 4321cc2 into main Nov 7, 2023
41 checks passed
@AlastairHolmes AlastairHolmes deleted the refactor/latest_finalized_header branch November 7, 2023 14:56
dandanlen pushed a commit that referenced this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants