Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: original order size and accumulative fees #4211

Merged
merged 6 commits into from
Nov 22, 2023
Merged

Conversation

AlastairHolmes
Copy link
Contributor

@AlastairHolmes AlastairHolmes commented Nov 7, 2023

This is the runtime part of PRO-932 and also PRO-897

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 81 lines in your changes are missing coverage. Please review.

Comparison is base (e6ad83e) 72% compared to head (f3c1fbf) 71%.
Report is 4 commits behind head on main.

❗ Current head f3c1fbf differs from pull request most recent head ab1f5d2. Consider uploading reports for the commit ab1f5d2 to get more accurate results

Files Patch % Lines
state-chain/amm/src/limit_orders/v1.rs 0% 30 Missing ⚠️
state-chain/amm/src/range_orders/v1.rs 0% 30 Missing ⚠️
state-chain/pallets/cf-pools/src/migrations/v1.rs 0% 13 Missing ⚠️
state-chain/amm/src/v1.rs 0% 5 Missing ⚠️
state-chain/pallets/cf-pools/src/lib.rs 40% 3 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #4211    +/-   ##
======================================
- Coverage     72%     71%    -0%     
======================================
  Files        385     388     +3     
  Lines      63554   63136   -418     
  Branches   63554   63136   -418     
======================================
- Hits       45448   45113   -335     
+ Misses     15749   15689    -60     
+ Partials    2357    2334    -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

linear bot commented Nov 13, 2023

PRO-932 Rpc/s for returning LP fees earned

This will mean I need to change the pools pallet storage to include a record of earnings per position, and per lp.

Also add the fees for a swap into the AssetSwapped Event

zoheb

@AlastairHolmes AlastairHolmes marked this pull request as ready for review November 13, 2023 10:30
@AlastairHolmes AlastairHolmes merged commit 65fe66f into main Nov 22, 2023
@AlastairHolmes AlastairHolmes deleted the feat/acc_fees branch November 22, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants