Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove pre-witnessing functionality #4358

Merged
merged 2 commits into from
Dec 22, 2023
Merged

fix: remove pre-witnessing functionality #4358

merged 2 commits into from
Dec 22, 2023

Conversation

AlastairHolmes
Copy link
Contributor

No description provided.

@codecov Codecov
Copy link

codecov bot commented Dec 19, 2023 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6ca9226) 71% compared to head (7b47548) 71%.

Files Patch % Lines
engine/src/witness/dot.rs 0% 1 Missing ⚠️
engine/src/witness/eth.rs 0% 1 Missing ⚠️
Additional details and impacted files 
@@          Coverage Diff           @@
##            main   #4358    +/-   ##
======================================
- Coverage     71%     71%    -0%     
======================================
  Files        394     394            
  Lines      67064   66824   -240     
  Branches   67064   66824   -240     
======================================
- Hits       47925   47702   -223     
+ Misses     16709   16691    -18     
- Partials    2430    2431     +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlastairHolmes AlastairHolmes marked this pull request as draft December 20, 2023 11:20
@AlastairHolmes
Copy link
Contributor Author

Just needs the re-enabling btc commit to be added

@AlastairHolmes AlastairHolmes force-pushed the remove-pre-witnessing-functionality branch from 20c12da to 7b47548 Compare December 22, 2023 10:02
@AlastairHolmes AlastairHolmes marked this pull request as ready for review December 22, 2023 10:02
@AlastairHolmes AlastairHolmes merged commit 9f87824 into main Dec 22, 2023
42 of 43 checks passed
@AlastairHolmes AlastairHolmes deleted the remove-pre-witnessing-functionality branch December 22, 2023 10:56
syan095 added a commit that referenced this pull request Jan 3, 2024
@syan095
Merge remote-tracking branch 'origin/main' into feat/improve-sub-prew…
d46c602 
…itness-swap

* origin/main:
  test: polkadot runtime update bouncer test (#4286)
  fix: can timeout when updating CFE version (#4365)
  feat: add chaintracking metric (#4369)
  fix: remove pre-witnessing functionality (#4358)
  chore: changelog 1.1 (#4330)
  pick: hotfixes from release branch (#4363)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msgmaxim msgmaxim msgmaxim approved these changes

@dandanlen dandanlen Awaiting requested review from dandanlen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlastairHolmes @msgmaxim