Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more accurate btc fees #4367

Merged
merged 5 commits into from
Dec 21, 2023
Merged

feat: more accurate btc fees #4367

merged 5 commits into from
Dec 21, 2023

Conversation

dandanlen
Copy link
Collaborator

Pull Request

Closes: PRO-1058

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have updated documentation where appropriate.

Summary

Please include a succinct description of the purpose and content of the PR. What problem does it solve, and how? Link issues, discussions, other PRs, and anything else that will help the reviewer.

@dandanlen dandanlen changed the title Fix/adjustbtc-fees feat: more accurate btc fees Dec 21, 2023
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (7c3aad0) 71% compared to head (fd06397) 71%.
Report is 2 commits behind head on release/1.1.

Files Patch % Lines
state-chain/chains/src/btc.rs 43% 8 Missing ⚠️
state-chain/pallets/cf-pools/src/migrations/v2.rs 0% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           release/1.1   #4367   +/-   ##
===========================================
- Coverage           71%     71%   -0%     
===========================================
  Files              393     394    +1     
  Lines            66578   66598   +20     
  Branches         66578   66598   +20     
===========================================
+ Hits             47502   47512   +10     
- Misses           16648   16656    +8     
- Partials          2428    2430    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dandanlen dandanlen merged commit 103520d into release/1.1 Dec 21, 2023
41 checks passed
@dandanlen dandanlen deleted the fix/adjustbtc-fees branch December 21, 2023 12:18
martin-chainflip pushed a commit that referenced this pull request Jan 8, 2024
martin-chainflip added a commit that referenced this pull request Jan 8, 2024
* fix: keep utxos even if swallowed (PRO-1068) (#4360)

* fix: network fee (#4364)

Co-authored-by: Daniel <daniel@chainflip.io>

* feat: more accurate btc fees (#4367)

* fix test

---------

Co-authored-by: dandanlen <3168260+dandanlen@users.noreply.github.com>
Co-authored-by: Alastair Holmes <42404303+AlastairHolmes@users.noreply.github.com>
Co-authored-by: Daniel <daniel@chainflip.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants