fix: rename slippage -> price impact #4679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure why but |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4679 +/- ##
======================================
- Coverage 72% 72% -0%
======================================
Files 414 414
Lines 68463 68383 -80
Branches 68463 68383 -80
======================================
- Hits 49253 49084 -169
- Misses 16807 16889 +82
- Partials 2403 2410 +7 ☔ View full report in Codecov by Sentry. |
marcellorigotti
changed the title
dandanlen
approved these changes
Mar 22, 2024
| @@ -289,9 +289,9 @@ pub mod pallet { | |||
| pub(super) type ScheduledLimitOrderUpdates<T: Config> = | |||
| StorageMap<_, Twox64Concat, BlockNumberFor<T>, Vec<LimitOrderUpdate<T>>, ValueQuery>; | |||
|
|
|||
| /// Maximum relative slippage for a single swap, measured in number of ticks. | |||
| /// Maximum relative price impact for a single swap, measured in number of ticks. | |||
There was a problem hiding this comment.
change the comment here not say relative.
dandanlen
pushed a commit
that referenced
this pull request
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-1254
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Renaming of slippage -> price delta
Non-Breaking changes