Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix a typo and minor grammar issue in PRACTICES.md #4695

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

kylezs
Copy link
Contributor

@kylezs kylezs commented Mar 25, 2024

Until we get the CI working for external contributors, I've included the changes from @umbr4g3 from here: #4434

@dandanlen dandanlen enabled auto-merge (squash) March 25, 2024 15:27
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72%. Comparing base (e146093) to head (fdb35d8).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #4695   +/-   ##
=====================================
  Coverage     72%     72%           
=====================================
  Files        415     415           
  Lines      68784   68784           
  Branches   68784   68784           
=====================================
+ Hits       49367   49373    +6     
+ Misses     17006   17005    -1     
+ Partials    2411    2406    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dandanlen dandanlen merged commit 932be5f into main Mar 25, 2024
43 checks passed
@dandanlen dandanlen deleted the doc/typos-practices branch March 25, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants