Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make benchmarks work again #4716

Merged
merged 7 commits into from
Apr 3, 2024
Merged

Conversation

dandanlen
Copy link
Collaborator

@dandanlen dandanlen commented Mar 28, 2024

This fixes the benchmarks that broke with the account deregistration PR, as well as some other benchmark related issues.

Most of the line count is just the updated weights files.

The issue was that the new deregistration requirements prevented the account being created/destroyed under some circumstances.

The solution was to introduce a new benchmark-only trait member to the AccountRoles trait.

@dandanlen dandanlen force-pushed the fix/funding-benchmarks-no-provider branch from 12d796e to 1b4bdbc Compare March 28, 2024 16:49
@dandanlen dandanlen requested a review from kylezs March 28, 2024 16:49
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 34.70000% with 653 lines in your changes are missing coverage. Please review.

Project coverage is 72%. Comparing base (5077a7c) to head (80b60d6).
Report is 1 commits behind head on main.

Files Patch % Lines
state-chain/pallets/cf-funding/src/weights.rs 0% 114 Missing ⚠️
...hain/pallets/cf-threshold-signature/src/weights.rs 49% 73 Missing ⚠️
state-chain/pallets/cf-swapping/src/weights.rs 0% 58 Missing ⚠️
state-chain/pallets/cf-pools/src/weights.rs 7% 56 Missing ⚠️
state-chain/pallets/cf-governance/src/weights.rs 35% 53 Missing ⚠️
state-chain/pallets/cf-validator/src/weights.rs 62% 52 Missing ⚠️
state-chain/pallets/cf-lp/src/weights.rs 0% 50 Missing ⚠️
...ate-chain/pallets/cf-ingress-egress/src/weights.rs 25% 48 Missing ⚠️
...n/pallets/cf-tokenholder-governance/src/weights.rs 29% 30 Missing ⚠️
state-chain/pallets/cf-broadcast/src/weights.rs 48% 28 Missing ⚠️
... and 10 more
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #4716    +/-   ##
======================================
- Coverage     72%     72%    -0%     
======================================
  Files        415     415            
  Lines      68971   68852   -119     
  Branches   68971   68852   -119     
======================================
- Hits       49630   49468   -162     
- Misses     16938   16969    +31     
- Partials    2403    2415    +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

const initBalance = await getBalance('Flip', redeemEthAddress);
console.log(`Initial ERC20-Flip balance: ${initBalance}`);
const initBalance = await getBalance('FLIP', redeemEthAddress);
console.log(`Initial ERC20-FLIP balance: ${initBalance}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 doesn't really seem relevant to the change? Bad merge?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, fixing.

@dandanlen dandanlen force-pushed the fix/funding-benchmarks-no-provider branch from ee29c6f to 80b60d6 Compare April 2, 2024 13:12
@dandanlen dandanlen merged commit bd6e480 into main Apr 3, 2024
46 checks passed
@dandanlen dandanlen deleted the fix/funding-benchmarks-no-provider branch April 3, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants