-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make benchmarks work again #4716
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandanlen
force-pushed
the
fix/funding-benchmarks-no-provider
branch
from
March 28, 2024 16:49
12d796e
to
1b4bdbc
Compare
kylezs
reviewed
Apr 2, 2024
bouncer/shared/fund_redeem.ts
Outdated
const initBalance = await getBalance('Flip', redeemEthAddress); | ||
console.log(`Initial ERC20-Flip balance: ${initBalance}`); | ||
const initBalance = await getBalance('FLIP', redeemEthAddress); | ||
console.log(`Initial ERC20-FLIP balance: ${initBalance}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀 doesn't really seem relevant to the change? Bad merge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, fixing.
martin-chainflip
approved these changes
Apr 2, 2024
dandanlen
force-pushed
the
fix/funding-benchmarks-no-provider
branch
from
April 2, 2024 13:12
ee29c6f
to
80b60d6
Compare
kylezs
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the benchmarks that broke with the account deregistration PR, as well as some other benchmark related issues.
Most of the line count is just the updated weights files.
The issue was that the new deregistration requirements prevented the account being created/destroyed under some circumstances.
The solution was to introduce a new benchmark-only trait member to the AccountRoles trait.