fix: restart node on compatible upgrade #4886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylezs
commented
May 22, 2024
| if (isCompatible) { | ||
| console.log('The versions are compatible.'); | ||
| await simpleRuntimeUpgrade(nextVersionWorkspacePath, true); | ||
|
|
||
| // TODO: Add restart nodes support, as in the prebuilt case. |
There was a problem hiding this comment.
leaving this as a TODO because I'm considering deleting the git-based upgrade test, feels a bit unnecessary now
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4886 +/- ##
======================================
- Coverage 72% 72% -0%
======================================
Files 428 428
Lines 73171 73026 -145
Branches 73171 73026 -145
======================================
- Hits 52685 52483 -202
- Misses 17933 17988 +55
- Partials 2553 2555 +2 ☔ View full report in Codecov by Sentry. |
ahasna
approved these changes
May 23, 2024
martin-chainflip
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
When the versions are "compatible" it doesn't mean the RPCs will be unbroken. So we have to start the node with the new version to ensure the RPC updates are reflected on the node.
e.g. see this failure: https://github.com/chainflip-io/chainflip-backend/actions/runs/9191091275/job/25277048379
Upgrade tests should pass now: https://github.com/chainflip-io/chainflip-backend/actions/runs/9208000827