fix: package should use old dylibs based on tags #4966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
kylezs
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4966 +/- ##
======================================
- Coverage 71% 71% -0%
======================================
Files 429 429
Lines 74095 73951 -144
Branches 74095 73951 -144
======================================
- Hits 52934 52732 -202
- Misses 18328 18382 +54
- Partials 2833 2837 +4 ☔ View full report in Codecov by Sentry. |
kylezs
force-pushed
the
fix/old-dylib-version
branch
from
d3e772b
to
7df4d5e
Compare
ahasna
approved these changes
Jun 14, 2024
kylezs
added a commit
that referenced
this pull request
Jun 14, 2024
dandanlen
pushed a commit
that referenced
this pull request
Jul 1, 2024
fix: package should use old dylibs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-1443
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
This fixes an issue where, if we had a release branch that had been tagged, causing release-berghain to run, then the next time we released off that branch, the "latest" release would actually be the previous patch release, which is not what we want.
Instead, if we're on release/1.4 we want to get the latest 1.3.x tag and use that.
Will need to cherry-pick this across to release too.