fix: print cause of settings error #4972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandanlen
added
the
non-breaking
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4972 +/- ##
======================================
- Coverage 71% 71% -0%
======================================
Files 429 429
Lines 74095 73951 -144
Branches 74095 73951 -144
======================================
- Hits 52934 52726 -208
- Misses 18328 18381 +53
- Partials 2833 2844 +11 ☔ View full report in Codecov by Sentry. |
kylezs
approved these changes
Jun 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
chainflip-bot
pushed a commit
that referenced
this pull request
Jun 17, 2024
(cherry picked from commit 83e9691)
dandanlen
added a commit
that referenced
this pull request
Jun 18, 2024
(cherry picked from commit 83e9691)
dandanlen
added a commit
that referenced
this pull request
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this just always printed:
Error reading settings: Error reading settingssince usingprintln!("{}", err)just prints the context but not the cause.