refactor(bouncer): multicast subscriptions #4980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4980 +/- ##
======================================
- Coverage 71% 71% -0%
======================================
Files 429 429
Lines 74061 73938 -123
Branches 74061 73938 -123
======================================
- Hits 52934 52730 -204
- Misses 18294 18369 +75
- Partials 2833 2839 +6 ☔ View full report in Codecov by Sentry. |
acdibble
force-pushed
the
refactor/multiplex-subscriptions
branch
from
e7dc4e5 to
fef9b00
Compare
kylezs
force-pushed
the
refactor/multiplex-subscriptions
branch
from
65df0ed to
4cbc471
Compare
kylezs
reviewed
Jun 19, 2024
| console.log(`Withdrawal requested, egressId: ${withdrawalRequestedEvent.data.egressId}`); | ||
| const BatchBroadcastRequestedEvent = await observeEvent(':BatchBroadcastRequested', { |
There was a problem hiding this comment.
Was just testing an implementation detail that's not relevant, and was the cause of flakiness as it introduces a race condition.
kylezs
approved these changes
Jun 19, 2024
dandanlen
pushed a commit
that referenced
this pull request
Jul 1, 2024
* refactor(bouncer): multicast subscriptions * reuse subscriptions * remove logs * tmp: run upgrade-test * fix: depends on try-runtime * add logs * more logs and shorten timeout * fix async issue * restore timeout * fix: start observing before submitting request * fix: remove awaiting on batch broadcast requested * remove logs * revert running upgrade-test on every push --------- Co-authored-by: kylezs <zsembery.kyle@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-xxx
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
We were creating 157 separate subscriptions.... this just creates one and multicasts it, hopefully eliminating the excessive memory usage we've been seeing.