test: engine-runner command line args passing filters correctly #5001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylezs
force-pushed
the
test/compatible-args
branch
2 times, most recently
from
480bf2f
to
0a2884a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5001 +/- ##
======================================
- Coverage 72% 72% -0%
======================================
Files 431 431
Lines 74782 74646 -136
Branches 74782 74646 -136
======================================
- Hits 53592 53401 -191
- Misses 18343 18396 +53
- Partials 2847 2849 +2 ☔ View full report in Codecov by Sentry. |
dandanlen
reviewed
Jun 26, 2024
| #[test] | ||
| fn incompatible_args_should_be_filtered_out() { | ||
| // create temporary file | ||
| let tempdir = tempfile::TempDir::new().unwrap(); |
There was a problem hiding this comment.
Does tempfile automatically clean up the temporary file that is created? Maybe we should delete it?
There was a problem hiding this comment.
Should be cleaned up on Drop: https://docs.rs/tempfile/latest/tempfile/#resource-leaking
dandanlen
approved these changes
Jun 26, 2024
AlastairHolmes
approved these changes
Jun 26, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
kylezs
requested review from
ahasna and
martin-chainflip
and removed request for
a team
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
kylezs
force-pushed
the
test/compatible-args
branch
4 times, most recently
from
c71dd42
to
41bc578
Compare
dandanlen
pushed a commit
that referenced
this pull request
Jul 1, 2024
* test: engine-runner command line args passing filters correctly * fix: should pass into new first * fix: remove unused sol.rpc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-1455
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
A bug slipped through into main, fixed here: #4982 - which is hard to pick up without a test like this one.