-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add fok params to SwapDepositAddressReady #5013
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5013 +/- ##
======================================
- Coverage 72% 72% -0%
======================================
Files 431 431
Lines 74790 74660 -130
Branches 74790 74660 -130
======================================
- Hits 53600 53411 -189
- Misses 18343 18399 +56
- Partials 2847 2850 +3 ☔ View full report in Codecov by Sentry. |
niklasnatter
approved these changes
Jul 1, 2024
dandanlen
approved these changes
Jul 1, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jul 1, 2024
Do we know what this cargo-deb error is? Can this be ignored/merged? |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jul 3, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jul 4, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jul 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jul 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jul 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
As per @niklasnatter request, adding FoK parameters (
refund_parameters
) to theSwapDepositAddressReady
event. Updated one of the test to check that it is correctly set. Also addedrefund_parameters
to the CLI'sSwapDepositAddress
since its purpose seems to be to observe the event and read its parameters (I'm not sure how this is used exactly, but I'm assuming this is converted to JSON, which means the change is non-breaking).