Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fok params to SwapDepositAddressReady #5013

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

msgmaxim
Copy link
Contributor

@msgmaxim msgmaxim commented Jul 1, 2024

Pull Request

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have updated documentation where appropriate.

Summary

As per @niklasnatter request, adding FoK parameters (refund_parameters) to the SwapDepositAddressReady event. Updated one of the test to check that it is correctly set. Also added refund_parameters to the CLI's SwapDepositAddress since its purpose seems to be to observe the event and read its parameters (I'm not sure how this is used exactly, but I'm assuming this is converted to JSON, which means the change is non-breaking).

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 72%. Comparing base (1582ee0) to head (32d5d52).

Files Patch % Lines
api/lib/src/lib.rs 0% 2 Missing ⚠️
state-chain/pallets/cf-swapping/src/lib.rs 67% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5013    +/-   ##
======================================
- Coverage     72%     72%    -0%     
======================================
  Files        431     431            
  Lines      74790   74660   -130     
  Branches   74790   74660   -130     
======================================
- Hits       53600   53411   -189     
- Misses     18343   18399    +56     
- Partials    2847    2850     +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dandanlen dandanlen added this pull request to the merge queue Jul 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 1, 2024
@msgmaxim
Copy link
Contributor Author

msgmaxim commented Jul 3, 2024

Do we know what this cargo-deb error is? Can this be ignored/merged?

@dandanlen dandanlen added this pull request to the merge queue Jul 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 3, 2024
@msgmaxim msgmaxim added this pull request to the merge queue Jul 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 4, 2024
@msgmaxim msgmaxim added this pull request to the merge queue Jul 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 5, 2024
@dandanlen dandanlen added this pull request to the merge queue Jul 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 5, 2024
@msgmaxim msgmaxim added this pull request to the merge queue Jul 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 8, 2024
@msgmaxim msgmaxim added this pull request to the merge queue Jul 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 8, 2024
@dandanlen dandanlen added this pull request to the merge queue Jul 8, 2024
Merged via the queue into main with commit 513450a Jul 8, 2024
47 checks passed
@dandanlen dandanlen deleted the feat/fok-params-in-events branch July 8, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants