Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pick: fix: grep correct spec_version (#5070) #5071

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Conversation

kylezs
Copy link
Contributor

@kylezs kylezs commented Jul 22, 2024

No description provided.

fix: treat as raw string
@kylezs kylezs changed the base branch from main to release/1.5 July 22, 2024 14:39
@kylezs kylezs requested a review from martin-chainflip July 22, 2024 14:40
@kylezs kylezs changed the title pick: fix: grep correct spec_version #5070 pick: fix: grep correct spec_version (#5070) Jul 22, 2024
@kylezs kylezs enabled auto-merge (squash) July 22, 2024 14:42
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71%. Comparing base (771eee5) to head (42da921).

Additional details and impacted files
@@             Coverage Diff              @@
##           release/1.5   #5071    +/-   ##
============================================
  Coverage           71%     71%            
============================================
  Files              441     442     +1     
  Lines            76171   76283   +112     
  Branches         76171   76283   +112     
============================================
+ Hits             54317   54418   +101     
- Misses           18969   18988    +19     
+ Partials          2885    2877     -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kylezs kylezs merged commit 8e25ef7 into release/1.5 Jul 22, 2024
48 checks passed
@kylezs kylezs deleted the pick/version-check branch July 22, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants