Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: bouncer cmd for FoK swap #5103

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Conversation

j4m1ef0rd
Copy link
Contributor

Pull Request

Closes: PRO-1537

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have updated documentation where appropriate.

Summary

  • Refactored the new swap command to use yargs to allow for more complex command line arguments.
  • Added the 3 FoK refund parmas as command line options.
  • Changed the maxBoostFeeBps to a command line option instead of an optional positional argument.

@j4m1ef0rd j4m1ef0rd force-pushed the refactor/bouncer-fok-swap-cmd branch from 7408beb to c3b04d8 Compare August 1, 2024 06:48
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71%. Comparing base (8050ef3) to head (8c23f79).
Report is 2 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5103    +/-   ##
======================================
- Coverage     71%     71%    -0%     
======================================
  Files        442     442            
  Lines      76751   76666    -85     
  Branches   76751   76666    -85     
======================================
- Hits       54603   54436   -167     
- Misses     19226   19290    +64     
- Partials    2922    2940    +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bouncer/commands/new_swap.ts Outdated Show resolved Hide resolved
@j4m1ef0rd j4m1ef0rd added this pull request to the merge queue Aug 4, 2024
Merged via the queue into main with commit 2154668 Aug 5, 2024
48 checks passed
@j4m1ef0rd j4m1ef0rd deleted the refactor/bouncer-fok-swap-cmd branch August 5, 2024 00:25
kylezs pushed a commit that referenced this pull request Aug 14, 2024
* refactor: new swap cmd can take refund params

* refactor: remove unneeded default min price
martin-chainflip pushed a commit that referenced this pull request Aug 14, 2024
* refactor: new swap cmd can take refund params

* refactor: remove unneeded default min price
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants